Skip to content

Fix: Enhance JoinRoom Component with Better Error Handling and Performance #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
imaheshno1 wants to merge 80 commits into
base: concept-react-components
Choose a base branch
from
Open

Fix: Enhance JoinRoom Component with Better Error Handling and Performance #121

imaheshno1 wants to merge 80 commits into from

Conversation

@imaheshno1
Copy link

@imaheshno1 imaheshno1 commented Oct 2, 2025

This PR introduces several improvements to the JoinRoom component, focusing on error handling, performance optimization, and user experience.

Changes

  • Fixed Memory Leaks:
    • Added proper cleanup for socket event listeners
    • Implemented timeout cleanup using useRef
  • Improved Error Handling:
    • Added user authentication check before joining a room
    • Enhanced error messages and their display
    • Added loading states to prevent multiple submissions
  • Performance Optimizations:
    • Memoized callbacks with useCallback
    • Optimized re-renders
    • Reduced unnecessary state updates
  • UI/UX Improvements:
    • Disabled buttons during loading
    • Added visual feedback for loading state
    • Prevented navigation during loading
    • Improved error message display
  • Code Quality:
    • Better code organization and structure
    • Added proper TypeScript-like type safety with JSDoc comments
    • Improved code readability and maintainability

Testing

  • Tested joining a room with valid code
  • Verified error handling for invalid codes
  • Checked loading states and button disabling
  • Verified proper cleanup on unmount
  • Tested keyboard navigation

Yogesh Manivannan and others added 30 commits June 23, 2025 17:33
Re-add roomController.js with full DB read/write logic
f28537e
@yep-yogesh
Merge pull request yep-yogesh#20 from kalviumcommunity/concept-db-rea…
a5ee638 
…dwrite

Re-add roomController.js with full DB read/write logic
@yep-yogesh
Merge pull request yep-yogesh#21 from kalviumcommunity/concept-react-…
aa0d3eb 
…components

Added reusable frontend React components: Navbar, AvatarGrid etc
Added game rules file upload (.txt) Concept - File Upload Functionality
67b868e
@yep-yogesh
Merge pull request yep-yogesh#22 from kalviumcommunity/concept-file-u…
131dfda 
…pload

Added game rules file upload (.txt) Concept - File Upload Functionality
Added email/password based authentication using Firebase
745b535
Removed Firebase-adminsdk.json for security reasons
ea9f23d
@yep-yogesh
Merge pull request yep-yogesh#23 from kalviumcommunity/concept-auth-p…
04bc5a9 
…assword

Added email/password based authentication using Firebase
Removed files temporarily to add them with the concept Authentication…
7366c32 
… using Google
Added Google Authentication with Firebase (3rd party auth)
bde2ac5
@yep-yogesh
Merge pull request yep-yogesh#24 from kalviumcommunity/concept-auth-g…
f805f99 
…oogle

Added Google Authentication with Firebase (3rd party auth)
Removed files temporarily to add them with the concept Update and Del…
b753ec2 
…ete Entity
Merge branch 'main' of https://github.com/kalviumcommunity/S74_Yogesh…
84f2564 
…_Capstone_Guessync
Implemented update and delete functionality in CreateRoom
1a354d0
@yep-yogesh
Merge pull request yep-yogesh#25 from kalviumcommunity/concept-update…
0a35cbc 
…-delete

Implemented update and delete functionality in CreateRoom
Removed files temporarily to add them with the concept Using JWT
7ec969f
Using Firebase JWT tokens in application
cf1256c
@yep-yogesh
Merge pull request yep-yogesh#26 from kalviumcommunity/concept-jwt-to…
fd48107 
…ken-firebase

Using Firebase JWT tokens in application
Removed files temporarily to add them with the concept git checkout -…
73db0c8 
…b concept-testing
Added 6 unit tests using Vitest & Testing Library
18ef307
@yep-yogesh
Merge pull request yep-yogesh#27 from kalviumcommunity/concept-testing
78276a8 
Added 6 unit tests using Vitest & Testing Library
Added Dockerfile to containerize app
bf7d181
@yep-yogesh
Merge pull request yep-yogesh#28 from kalviumcommunity/concept-docker…
4e6ad44 
…file

Added Dockerfile to containerize app
Integrated LangChain.js for AI-powered hint generation
ab1f46f
@yep-yogesh
Merge pull request yep-yogesh#29 from kalviumcommunity/concept-langchain
0dcccef 
Integrated LangChain.js for AI-powered hint generation
Added payment Link for Payment Gateway integration in AboutDev page
0f54bd7
@yep-yogesh
Merge pull request yep-yogesh#30 from kalviumcommunity/concept-paymen…
5f6ed3d 
…t-gateway

Added payment Link for Payment Gateway integration in AboutDev page
Added cronjob to auto-delete expired rooms every 20 mins
afbfef9
@yep-yogesh
Merge pull request yep-yogesh#31 from kalviumcommunity/concept-cronjob
297faa3 
Added cronjob to auto-delete expired rooms every 20 mins
Added WebSocket-based real-time multiplayer communication
23ee372
Yogesh Manivannan and others added 27 commits June 30, 2025 22:41
Fix: Add Vite to devDependencies for Netlify build
03e5169
Add netlify.toml to fix Vite build
3449762
Fix: Add Netlify redirect for React Router
2602981
Fix: Add production CORS for Netlify
ede573d
@yep-yogesh
Updated README.md with Deployment links
cde05d7
Fix: Added Icon for Deployed Link
241d74d
Fix: Added Icon for Deployed Link
fb1a421
Fix: Fixed Api for Room Creation
181b276
Fix: Fixed Api for Socket
eaddd94
Fix: Fixed Https for Socket
62da0ec
@yep-yogesh
Added redirect to home
d86751a
@yep-yogesh
Updated Readme with Animated GIF
e95e0a5
@yep-yogesh
Merge pull request yep-yogesh#47 from kalviumcommunity/guessync-readme
bccf3c7 
Updated Readme with Animated GIF
@yep-yogesh
changed gif size
d807486
@yep-yogesh
enhancement readme
7fc0c81
@yep-yogesh
updated readme
177e548
@yep-yogesh
Fixed Responsiveness for every page
76c9ba4
@yep-yogesh
Merge pull request yep-yogesh#48 from kalviumcommunity/fix-responiveness
3be304f 
Fixed Responsiveness for every page
@yep-yogesh
Added subtle microanimations
743f587
@yep-yogesh
Merge pull request yep-yogesh#49 from kalviumcommunity/ui-howtoplay
fd40b13 
Added subtle microanimations
@yep-yogesh
Enhanced UI in profile page
4d09f3b
@yep-yogesh
Merge pull request yep-yogesh#50 from kalviumcommunity/ui-profile
4952128 
Enhanced UI in profile page
@yep-yogesh
Added MIT License to the project
d818fae
@yep-yogesh
Added .env example to setup
9b80f64
@yep-yogesh
Merge pull request yep-yogesh#51 from yep-yogesh/env-sample
7dc5c99 
Added .env example to setup
@yep-yogesh
Updated README with local development steps
e58e6e1 
Updated README to include Gemini API and deployment details.
@imaheshno1
Fix: Enhance JoinRoom Component with Better Error Handling and Perfor…
03246e3 
…mance
@yep-yogesh
Copy link
Owner

yep-yogesh commented Oct 2, 2025

Hey @imaheshno1 pls star the repo and ping again

@imaheshno1
Copy link
Author

imaheshno1 commented Oct 2, 2025 via email

@imaheshno1
Copy link
Author

imaheshno1 commented Oct 4, 2025

Hey @imaheshno1 pls star the repo and ping again

@yep-yogesh bro check it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@imaheshno1 @yep-yogesh @varshakannan-hub @reshma-devraj @Ahamed1846